mapbox/mapbox-gl-js

Mechanism to access existing controls in map

Open

#7,682 opened on Dec 6, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (2,203 forks)batch import
api :memo:feature :green_apple:good first issue

Repository metrics

Stars
 (10,532 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Motivation

I'm trying to implement a utility function to solve #6531: map.U.lockRotation().

Because the navigation control would have already been constructed and added to the map, it's too late to just not add it. Hence I need to find the existing navigation control and either modify it, or remove it then re-add it.

Design Alternatives

  • map.getControl(mapboxgl.NavigationControl) ?

Contributor guide

Research direction
Investigate how controls are stored in the map object and design an API to retrieve them by type.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75