mapbox/mapbox-gl-js

validate sprite URL is defined when a style uses sprite-dependent properties

Open

#6,823 opened on Jun 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,203 forks)batch import
good first issuetesting :100:

Repository metrics

Stars
 (10,532 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

mapbox-gl-js version:

0.45.0

browser:

Google Chrome | 66.0.3359.181 (Official Build) (64-bit)

Steps to Trigger Behavior

  1. Toggle between symbol-osm (style based on OSM raster TMS) and symbol-streets (mapbox streets style)

Link to Demonstration

https://mapkibera.github.io/counties/test.html

Expected Behavior

symbol layer visible whether OSM TMS style or mapbox streets style

Actual Behavior

symbol layer only visible with mapbox streets style

Contributor guide

Research direction
Investigate the sprite loading logic when switching styles. Check if the sprite URL is properly set for non Mapbox styles and trace the code path that handles sprite dependent properties like icon image.
Tech stack
javascript
Domain
frontendweb devapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptMapbox GL JS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40