mapbox/mapbox-gl-js

Do not handle video loading errors

Open

#5,646 opened on Nov 10, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
api :memo:good first issue

Description

In src/util/ajax.js, getVideo seems not handle any loading errors.

And Also, I think it's useless to return video in the end. We should get video in callback.

https://github.com/mapbox/mapbox-gl-js/blob/master/src/util/ajax.js#L149

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsError handling in JavaScriptFamiliarity with callbacks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine src/util/ajax.js, specifically the getVideo function around line 149. Add error handling to the video loading process, typically by attaching an 'error' event listener to the HTMLVideoElement. Also consider modifying the function to accept a callback parameter to return the video element or handle the error accordingly. Check existing patterns for error handling in similar functions in the file.