mapbox/mapbox-gl-js

Do not handle video loading errors

Open

#5,646 opened on Nov 10, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,203 forks)batch import
api :memo:good first issue

Repository metrics

Stars
 (10,532 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In src/util/ajax.js, getVideo seems not handle any loading errors.

And Also, I think it's useless to return video in the end. We should get video in callback.

https://github.com/mapbox/mapbox-gl-js/blob/master/src/util/ajax.js#L149

Contributor guide

Research direction
Inspect the getVideo function in src/util/ajax.js, add error handling for video loading, and consider returning video via callback instead of direct return.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75