mapbox/mapbox-gl-js

Add an error message for calling "GeoJSONSource#setData" for a style that doesn't exist

Open

#2,602 opened on May 22, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
feature :green_apple:good first issue

Description

Can this error message be improved?

(link removed)

Step 1) press the [+] button Step 2) Notice the specific error message

dispatcher.js:32 Uncaught TypeError: Cannot read property 'send' of undefined

The dispatcher.js:32 that doesn't give any hints whatsoever for me and probably other api users.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsMapbox GL JS source API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The error occurs in dispatcher.js at line 32 when calling GeoJSONSource#setData on a style that does not exist. To add a meaningful error message, investigate the GeoJSONSource.setData method in the mapbox gl js source code. Determine where the style reference is used and add a check to throw a descriptive error if the style is missing. The issue provides clear steps to reproduce and the desired outcome is a user friendly error instead of an obscure TypeError.