mapbox/mapbox-gl-js

Fitbounds with center option not doing expected thing

Open

#11,337 opened on Dec 10, 2021

View on GitHub
 (7 comments) (2 reactions) (0 assignees)JavaScript (10,532 stars) (2,203 forks)batch import
good first issue

Description

mapbox-gl-js version:2.6.1

browser:Chrome

Steps to Trigger Behavior

1.create LngLatBounds as bounds 2 .use map.fitBounds and pass the center option to it

Link to Demonstration

check out this link for more info: https://jsbin.com/zodotod/edit?html,output

Expected Behavior

The bounds should be in the view and the center of the map should be the center option

Actual Behavior

Just flyTo the center

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
basic JavaScriptfamiliarity with mapbox gl js APIunderstanding of map transformations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining the fitBounds implementation in the mapbox gl js source, likely in src/geo/transform.js. The bug is that when the center option is passed, the map incorrectly performs a flyTo instead of fitting the bounds with the specified center. Look at how the center option interacts with the bounds calculation in the fitBounds method. Check the issue comments for any discussion about expected behavior vs actual, and search for any related PRs or commits that may have attempted a fix. Reproduce the issue using the provided JS Bin to understand the current behavior.