mapbox/mapbox-gl-js

FeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same

Open

#10,049 opened on Oct 23, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,203 forks)batch import
good first issue

Repository metrics

Stars
 (10,532 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :

https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L88-L100 https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L102-L114

I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?

// No loop
this.map.removeFeatureState({source: 'land'});

Maybe also source-property level like this?

// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');

Contributor guide

Research direction
Compare the two benchmark functions in bench/benchmarks/remove paint state.js, line 88-100 and line 102-114. The issue states they are identical, but one should test source level removal (e.g., map.removeFeatureState({source: 'land'})) and possibly source property level removal. Inspect the map.removeFeatureState API and modify the second benchmark to call it without a loop, removing state for the entire source or a specific property.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60