Stream does not complete on ROLLBACK_FAILED

Open Beginner friendly
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
aws, javascript
Domain
cloud

Research direction

Start at line 83, where stack operation statuses are checked, and compare the handling of ROLLBACK_FAILED with the existing completion condition. Update the condition so a failed rollback ends the stream as completed, then verify that the stream terminates for this status.

Written by the indexing model from the issue text.

Description

assembly-line

When a stack operation fails and the rollback fails as well, the stream should end be completed.
Thus, in line 83 I think you should check for ROLLBACK_FAILED too.

Dominant language
JavaScript
Stars
8
Forks
3
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/cfn-stack-event-stream

All issues in mapbox/cfn-stack-event-stream

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.