mapbox/carto

Possibly suboptimal translation to XML

Open

#20 opened on Mar 7, 2011

View on GitHub
 (18 comments) (0 reactions) (0 assignees)JavaScript (132 forks)auto 404
help wantedperformancewishlist

Repository metrics

Stars
 (658 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm not sure whether this is a bug, but I managed to create ~50 lines of Carto that get translated into something like 12,000 lines of XML. I probably should just be breaking things up differently, but perhaps there's room for optimization on Carto's side as well.

The offending style is at https://gist.github.com/859095 and the data to go with it is http://dl.dropbox.com/u/2398828/country-labels.geojson

Not the main issue, but I noticed many identical fontsets are created as well.

Contributor guide

Research direction
Investigate the Carto source code to understand how the XML output is generated and identify areas where redundant or overly verbose XML is produced. Look at the compiled output and correlate it with the input Carto style to find potential optimizations.
Tech stack
javascript
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45