assert.deepEqual is not strict
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- testing-qa
Research direction
Reproduce the shown assert.deepEqual case, then locate the assert.deepEqual implementation in the repository. Compare its behavior with node-deep-equal using opts.strict; done means ['32'] and [32] are no longer considered equal and the relevant test coverage passes.
Written by the indexing model from the issue text.
Description
// doesn't throw
assert.deepEqual(['32'], [32]);
Look into switching to https://github.com/substack/node-deep-equal with opts.strict
- Dominant language
- JavaScript
- Stars
- 5
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/assert-http
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/assert-http#16 ·
-
Unit tests Open
mapbox/assert-http#12 · 1 assignee ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
mapbox/assert-http#1 ·
All issues in mapbox/assert-http
Similar issues
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
AllTheMods/ATM-10-L#19 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SignalK/n2k-signalk#345 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
JuliaPluto/PlutoPlotly.jl#72 ·