mandiant/flare-fakenet-ng

Diverter failed calling GetBestInterface - error output not informative enough

Open

#138 opened on Feb 26, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Python (1,626 stars) (359 forks)batch import
enhancementgood first issue

Description

This error message is very technically specific and not very helpful. It would be helpful to those who use FakeNet-NG to confirm one or more reasons why this error message can arise, and indicate that information in the error message along with suggested troubleshooting steps.

Upon starting up, FakeNet-NG may display this error:

02/26/20 11:49:52 AM [          Diverter] Failed calling GetBestInterface

This may mean that a network interface with a valid IP address could not be identified. Ensuring that the guest is at least attached to a host-only network and has valid settings from DHCP may resolve the error.

Contributor guide

Tech stack
python
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonbasic understanding of networking
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the Diverter class in the source code, likely in a file named diverter.py. Find the method that calls GetBestInterface and produces the error message. Modify the error handling to catch specific exceptions and include reasons for failure, such as missing network interface or DHCP issues. Update the error message to suggest checking network configuration and ensure the change follows the existing logging style.