makeomatic/redux-connect

filter-ed promises not being executed in componentDidMount

Open

#30 opened on Jun 16, 2016

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (550 stars) (73 forks)batch import
bugenhancementhelp wanted

Description

BEGIN_GLOBAL_LOAD/END_GLOBAL_LOAD are dispatched on the client side even when filter stops the asyncConnect from blocking the render function. However, once the component is mounted, since the redux has saved the state loaded as true, it does not fetch the data. Due to this you have to manually redo the logic for re-fetching data in these instances. It would be nice to have some logic to ascertain that the promise is executed in componentDidMount.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with redux connectReact component lifecycleJavaScript promises
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the `asyncConnect` decorator implementation in the redux connect source code, focusing on how the `filter` prop affects promise execution and state management in `componentDidMount`. Review the issue comments for additional context and potential solutions. Consider creating a minimal reproduction and testing the expected behavior.