makeomatic/redux-connect

DeprecationWarning: Unhandled promise rejections are deprecated.

Open

#103 opened on Jan 23, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (73 forks)batch import
help wantedquestion

Repository metrics

Stars
 (550 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Everything is working pretty well but when I refresh on 1 Container out of 5 that are using redux-connect, I get this:

(node:27184) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Then I realize, the documentation is missing catch for loadOnServer method. I think the Readme needs to be updated.

Example:

loadOnServer({...renderProps, store}).then(() => {
        const components = renderToStaticMarkup(
          <Provider store={store}>
             <ReduxAsyncConnect {...renderProps} />
          </Provider>
        );
        res.status(200);
        res.send('<!doctype html>\n' +
          renderToString(
            <InitialPage
              assets={webpackIsomorphicTools.assets()}
              component={components}
              store={store}
            />
          )
        );
      })
      .catch(err => {
        console.log('Caught Error in Server Render: ');
        console.log(err);
      });

Contributor guide