madpah/serializable

style: get rid of unnecessary type conversions

Open

#23 opened on Sep 28, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (5 forks)auto 404
help wanted

Repository metrics

Stars
 (7 stars)
PR merge metrics
 (PR metrics pending)

Description

examples:

# is string already!  why the cast? 
            if type(type_) == str:
                type_to_parse = str(type_)

# is in list already! why the cast? 
                    if results.get('array_type', None) in self._SORTED_CONTAINERS_TYPES:
                        mapped_array_type = self._SORTED_CONTAINERS_TYPES.get(str(results.get("array_type")))

Contributor guide

Research direction
Search the codebase for patterns where str() is called on a variable that is already a string, especially in the provided examples (type() check and get() calls), and remove the unnecessary conversion. Also look for similar unnecessary casts elsewhere.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90