Dont add to ssh-agent unless specified
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- authentication, security
Research direction
Start in blessclient/client.py at lines 594-597 and trace how the client options are passed to the SSH-agent handling. Add a parameter that disables adding the Identity file while preserving the existing behavior by default; done means the wrapper use case can opt out without affecting other credentials.
Written by the indexing model from the issue text.
Description
I would suggest implementing a parameter that allows stopping bless from adding the Identity file to ssh-agent.
Namely this lines: https://github.com/lyft/python-blessclient/blob/master/blessclient/client.py#L594-L597
Given a config like:
Match exec "env | grep -q BLESS_COMPLETE || /Users/stype/blessclient/blessclient.run --gui --host '%h'"
IdentityFile ~/.ssh/blessid
this is not required and could interfere with other credentials.
I think this is required when doing a wrapper around the ssh command but in that case its easy to toggle on in the script.
If this is accepted I can create a PR to cleanup/implement this.
- Dominant language
- Python
- Stars
- 117
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lyft/python-blessclient
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
lyft/python-blessclient#30 · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
lyft/python-blessclient#26 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
lyft/python-blessclient#22 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 28/100
lyft/python-blessclient#20 · 2 comments ·
All issues in lyft/python-blessclient
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·