lukepighetti/fluro

Allow custom route for notFoundHandler

Open

#226 opened on Mar 12, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Dart (411 forks)batch import
good first issue

Repository metrics

Stars
 (3,714 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi

Great package. I have only one issue and that is the notFoundHandler. You can only supply a handler and not a route. So you cannot apply any animation when displaying the notFoundHandler. I see in your source that you hard code it to the MaterialRoute. Can this be changed to enable custom routes?

Thanks Gummi

Contributor guide

Research direction
Examine the library source code to modify the notFoundHandler to accept a custom route, similar to how other routes are defined, and ensure animations work with the custom route.
Tech stack
dart
Domain
mobilefrontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Flutterrouting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75