Add remote_address assignment to Context
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- crystal
- Domain
- backend
Research direction
Start with src/charms/request_extensions.cr and src/lucky/remote_ip_handler.cr, then compare the Crystal 1.22 change linked in the issue. Add the remote_address assignment to HTTP::Server::Context behind the 1.22 compatibility gate, while preserving current behavior for older versions. Done means the context receives the remote address without relying solely on the request patch.
Written by the indexing model from the issue text.
Description
Starting in Crystal 1.22, HTTP::Server::Context will have a remote_address property
https://github.com/crystal-lang/crystal/commit/db94c7a7d71f5f1b1b695a4a3a7e22e25af98ac0
Lucky currently patches HTTP::Request for this
We should add this in and gate to 1.22 so we can eventually just get rid of the request patch
- Dominant language
- Crystal
- Stars
- 2.7k
- Forks
- 173
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from luckyframework/lucky
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
luckyframework/lucky#2041 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
luckyframework/lucky#2039 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
luckyframework/lucky#2049 ·
-
Asset builder system Open
Difficulty 5/5 Over a week Newbie friendliness 20/100
luckyframework/lucky#1980 · 1 reaction ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
luckyframework/lucky#1968 · 2 comments ·
All issues in luckyframework/lucky
Similar issues
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100