luanti-org/luanti

Add a confirmation prompt to /clearobjects and /clearobjects quick

Open

#6,918 opened on Jan 15, 2018

View on GitHub
 (8 comments) (4 reactions) (0 assignees)C++ (2,395 forks)auto 404
@ Server / Client / Env.Concept approvedLow priorityRequest / Suggestiongood first issue

Repository metrics

Stars
 (13,341 stars)
PR merge metrics
 (PR metrics pending)

Description

It already happened to me a lot of times that I accidentally typed /clearobjects instead of //clearobjects (command from World Edit to remove objects in a marked region) and had all objects on the server deleted.

I suggest to add a prompt (chat message) that asks the user if they really want to proceed with this action and that it might take a long time (in full mode).

If server owners run those commands by accident (for whatever reason), A LOT of progress could get lost depending on the game type and mods).

EDIT: Removed formspec as prompt option since a chat message is more than enough.

Contributor guide

Research direction
Investigate the current implementation of /clearobjects and /clearobjects quick in the server command handler. Add a confirmation step that sends a chat message to the user asking for confirmation before executing the deletion.
Tech stack
lua
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65