luanfonceca/speakerfight

Not accept proposals before the `accept_proposals_at` date.

Open

#306 opened on Oct 9, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (135 forks)github user discovery
enhancementhacktoberfestnormal

Repository metrics

Stars
 (342 stars)
PR merge metrics
 (PR metrics pending)

Description

This issues depends on #304.

if some event has defined the accept_proposals_at field, we can only accept proposals after that time, this should create some changes on the Models, Views and tests.

Tasks:

  • Check if the accept_proposals_at date has passed.
  • Restrict the cases that the proposal cant be created and return a Message for the user.
  • Add tests to assert that the a proposal cannot be created after the date.

Contributor guide

Research direction
Implement date validation by checking if the current time is after `accept proposals at` in the model; prevent proposal creation in views and add corresponding tests.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60