luanfonceca/speakerfight

User should be redirected to original page after sign in

Open

#203 opened on Mar 16, 2017

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (135 forks)github user discovery
hacktoberfestreadywontfix

Repository metrics

Stars
 (342 stars)
PR merge metrics
 (PR metrics pending)

Description

Ideally, user should be redirected to original page after sign in. This doesn't seem to be the current behavior.

Steps to reproduce:

  1. Go to some event page, like http://speakerfight.com/events/python-sudeste-2017-palestras/
  2. Click "Sign in"
  3. Click Github
  4. User is now on http://speakerfight.com/events/, not the event page

Tip: this can probably be implemented with HTTP_REFERER header.

Contributor guide

Research direction
Examine the sign in handler to identify where the original URL is lost; implement redirect using the HTTP REFERER header or store the referring URL in the session.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75