lsd-rs/lsd

icon theme should support icons by prefix

Open

#726 opened on Aug 19, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (13,400 stars) (434 forks)batch import
area/themegood first issuekind/enhancement

Description

after https://github.com/Peltoche/lsd/pull/707 merged, we have icon themes, it should support icons by prefix, like log.lsd.0, log.lsd.1 can use a icon for log prefix

Contributor guide

Tech stack
rust
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of RustFamiliarity with lsd's icon theme system (PR #707)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the icon theme implementation introduced in PR #707 (linked in issue). Look at how themes are loaded and matched. The feature requires modifying the matching logic to allow prefix based matching (e.g., 'log.lsd.0' should use the 'log' icon). Consider adding a new field in the theme configuration or extending the matching algorithm. Test with various file extensions and prefixes.