lsd-rs/lsd

Add `ls_colors` option to theme

Open

#608 opened on Jan 17, 2022

View on GitHub
 (2 comments) (4 reactions) (0 assignees)Rust (13,400 stars) (434 forks)batch import
area/themegood first issuekind/enhancement

Description

As of now, we support theme for colors, and still use ls_colors for file name colors, how about adding the ls_colors option to the theme configuration file, and so that we can configure all the colors in one place.

also, there is something that needs to be covered:

  1. the ls_colors in the theme should be optional, and fall back to LS_COLORS env
  2. the one in themes should overwrite the env one

@meain

Contributor guide

Tech stack
rust
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingFamiliarity with lsd's theme configurationUnderstanding of LS COLORS environment variable
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Explore the current theme configuration implementation in the lsd source code, particularly how colors are handled. The issue suggests adding an `ls colors` field to the theme struct (likely in src/theme.rs or similar). Ensure the new option is optional and falls back to the `LS COLORS` environment variable. Check if there are any existing tests for theme parsing that need updating.
Add `ls_colors` option to theme · lsd-rs/lsd#608 | Good First Issue