lsd-rs/lsd

Add `ls_colors` option to theme

Open

#608 opened on Jan 17, 2022

View on GitHub
 (2 comments) (4 reactions) (0 assignees)Rust (434 forks)batch import
area/themegood first issuekind/enhancement

Repository metrics

Stars
 (13,400 stars)
PR merge metrics
 (Avg merge 34d 3h) (2 merged PRs in 30d)

Description

As of now, we support theme for colors, and still use ls_colors for file name colors, how about adding the ls_colors option to the theme configuration file, and so that we can configure all the colors in one place.

also, there is something that needs to be covered:

  1. the ls_colors in the theme should be optional, and fall back to LS_COLORS env
  2. the one in themes should overwrite the env one

@meain

Contributor guide

Research direction
Examine the existing theme configuration structure in the lsd source code, understand how LS COLORS environment variable is currently used, and implement an optional 'ls colors' field in the theme config that can override the env variable but fall back to it.
Tech stack
rust
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70