Misleading grid / column output in some cases · lsd-rs/lsd#594

(3 comments) (1 reaction) (0 assignees)Rust (13,400 stars) (434 forks)batch import

good first issuekind/enhancement

Description

os: macOS Monterey (12.0.1)
lsd --version: lsd 0.20.1 (also checked version built from https://github.com/Peltoche/lsd.git?branch=master#0a3a6f10)
echo $TERM: xterm-256color
echo $LS_COLORS: Empty / uninitialized

Expected behavior

With some long filenames in a directory, columnar output (the default?) can become misleading. Would be preferable to replicate the output of GNU ls in this case. The little video below shows both the expected and actual behaviors.

Actual behavior

Please see the video. In it, file_16 goes into column 2, and off-screen (!) making it seem like there are no more files beyond file_15_....

To reproduce this, you need this:

# Set terminal window's size to 14 rows & 91 columns
$ seq -f "file_%02g" 00 16 | xargs touch
$ mv file_00 file_00_abcdefghijklmnopqrstuvwxyz_abcdefghiklmnopqrstuvwxyz
$ mv file_15 file_15_abcdefghijklmnopqrstuvwxyz_abcdefghiklmnopqrstuvwxyz

This happens at all sizes of the terminal window. I've reduced it here, to make it easier to reproduce.

https://user-images.githubusercontent.com/172235/144849060-cfcd8286-cfd1-4dde-a699-43c8e1900c28.mp4

Contributor guide

Tech stack: rust
Domain: cli
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: stale
Clarity: mostly clear
Prerequisites: Basic RustUnderstanding of terminal layout
Newbie friendliness: 50
Research direction: Investigate the grid/column layout logic in the source code, likely in src/display.rs or a related module. Focus on how column widths are calculated and how long filenames cause misalignment. Look at the term grid crate usage to understand the expected behavior. Consider adjusting the column count or adding truncation logic.