lpil/rustexp

Support non-unicode flag

Open

#10 opened on Apr 2, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Rust (21 forks)github user discovery
help wanted

Repository metrics

Stars
 (130 stars)
PR merge metrics
 (PR metrics pending)

Description

It would be cool to support the regex::bytes::Regex matcher using the non-unicode flag. If I try this regex:

(?-u).

I get the following error:

Syntax(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
regex parse error:
    (?-u).
         ^
error: pattern can match invalid UTF-8
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)

In fact you may just want to use the regex::bytes::Regex unconditionally.

Contributor guide

Research direction
Examine the current regex::Regex usage in the codebase and replace it with regex::bytes::Regex to support non unicode patterns. Ensure the UI correctly displays matches for byte oriented regex.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70