lostisland/faraday

Requests can no longer be converted to simple JSON

Open

#535 opened on Oct 13, 2015

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Ruby (5,861 stars) (997 forks)batch import
featurehelp wanted

Description

fba7ce503d2be7bd88229f95107559a14c98821c causes a stack too deep to occur when attempting to call to_json, due to the nested env/request nature of the objects.

Some context: We have been logging the json version of faraday response objects for verification purposes when performing sensitive data changes through faraday requests; This is no longer possible.

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Ruby knowledgeunderstanding of Faraday response objects
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate commit fba7ce503d2be7bd88229f95107559a14c98821c which introduced the nesting causing stack overflow. Look at the `to json` method in Faraday's response object and determine how to serialize without infinite recursion. Consider adding a custom `as json` or `to json` override that excludes the `env`/`request` parts or uses a depth limit.
Requests can no longer be converted to simple JSON · lostisland/faraday#535 | Good First Issue