lostisland/faraday

Requests can no longer be converted to simple JSON

Open

#535 opened on Oct 13, 2015

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Ruby (997 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (5,861 stars)
PR merge metrics
 (Avg merge 53m) (3 merged PRs in 30d)

Description

fba7ce503d2be7bd88229f95107559a14c98821c causes a stack too deep to occur when attempting to call to_json, due to the nested env/request nature of the objects.

Some context: We have been logging the json version of faraday response objects for verification purposes when performing sensitive data changes through faraday requests; This is no longer possible.

Contributor guide

Research direction
Identify the recursive structure causing stack overflow when calling to json. Investigate the commit fba7ce5 and consider modifying the serialization to avoid deep nesting or implement a custom to json method.
Tech stack
ruby
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyFaraday
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60