lostisland/faraday

Please revisit the comma separated header collapsing decision.

Open

#1,120 opened on Jan 22, 2020

View on GitHub
 (6 comments) (1 reaction) (0 assignees)Ruby (5,861 stars) (997 forks)batch import
featurehelp wanted

Description

There was a decision to concatenate multiple header values using comma as a delimiter in the past. (https://github.com/lostisland/faraday/issues/44) And this is the real-world consequences of the decision. https://github.com/sparklemotion/http-cookie/issues/28

Could you somehow provide a way to access raw HTTP headers?

Contributor guide

Tech stack
None
Domain
apibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with faraday middlewareunderstanding of HTTP header concatenation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the historical decision in issue #44 where header concatenation was chosen. Examine the current header handling code in Faraday's Response or middleware, particularly how headers are stored and accessed. Look at the external http cookie issue to understand real world impact. Consider implementing a method to expose raw headers (e.g., `response.raw headers`) that returns headers as a hash of arrays. Check if any existing PRs or discussions address this.