loryjs/lory

BUG: Browser history on drag

Open

#752 opened on Oct 23, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,284 stars) (256 forks)batch import
help wantedwontfix

Description

When grabbing left or right triggers browser Back or Next. Using windows 10 Tablet + Google Chrome Firefox does not have this feature (go back dragging), so no problems. In edge is worse, the slider does not move and go back

screenshot

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is that horizontal drag on the slider triggers browser back/forward navigation. The fix likely involves calling event.preventDefault() on touchstart/touchmove events to prevent default browser behavior. Investigate the event handling in lory.js, particularly the touch action handlers. Also check if passive event listeners are used, as they can prevent preventDefault from working. Ensure that only horizontal drags are prevented, not vertical scrolling.