lorenzodifuccia/safaribooks

Images in CSS are not downloaded

Open

#157 opened on Nov 26, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (4,338 stars) (660 forks)batch import
bughelp wantedneed more info

Description

Hi,

It seems that images in the CSS are not downloaded, like

:after{content:url(css_assets/titlepage_footer_ebook.png);

Not familiar with Python, but I would try to fix this.

Thank you, Justin

Contributor guide

Tech stack
python
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic PythonCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the CSS parsing logic in the scraper or downloader modules. Look for how CSS rules are processed and ensure image URLs are resolved and downloaded. Check if the issue stems from missing handling of css assets paths or incomplete attribute extraction.
Images in CSS are not downloaded · lorenzodifuccia/safaribooks#157 | Good First Issue