lorenzodifuccia/safaribooks

Images in CSS are not downloaded

Open

#157 opened on Nov 26, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (660 forks)batch import
bughelp wantedneed more info

Repository metrics

Stars
 (4,338 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

It seems that images in the CSS are not downloaded, like

:after{content:url(css_assets/titlepage_footer_ebook.png);

Not familiar with Python, but I would try to fix this.

Thank you, Justin

Contributor guide

Research direction
Examine the CSS parsing and asset download logic in the codebase. Find where CSS content is processed and ensure that `url()` references are extracted and downloaded.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75