lordmauve/pgzero

music.is_playing() appears to require an argument

Open

#289 opened on Mar 28, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (472 stars) (185 forks)batch import
buggood first issue

Description

Hi, It would appear that music.is_playing() requires an argument. The argument is not mentioned in the documentation and in the source it appears to be ignored. If the intention is to be able to ask whether a particular music file is currently playing (which would be nice seeing as though you can queue multiple files) then can I suggest the argument is optional and if not passed means ANY music file is playing.

Contributor guide

Tech stack
python
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonpgzero
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look into the source file for music.is playing() in pgzero (likely pgzero/music.py). Understand the current implementation that requires an argument but ignores it. Propose changes to make the argument optional and update documentation accordingly.