lordmauve/pgzero

Initialise Pygame mixer lazily

Open

#110 opened on Aug 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (472 stars) (185 forks)batch import
enhancementgood first issue

Description

Initialising the mixer causes Pygame to burn one whole CPU on Linux:

https://github.com/pygame/pygame/issues/331

Pygame Zero should initialise the mixer lazily (eg. when sounds are loaded) to avoid suffering performance problems if the mixer is not needed.

Contributor guide

Tech stack
python
Domain
performance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python basicsPygame basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the pgzero source code to find where the mixer is initialized (likely in the main module or a startup function). Check the linked pygame issue #331 for details on the CPU burn. Implement lazy initialization so the mixer is only started when a sound is loaded. Modify the relevant code to defer pygame.mixer.init() until needed.