loopbackio/loopback-connector

Filtering with non existing / declared field is ignored / skipped

Open

#125 opened on May 31, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (101 forks)auto 404
bughelp wantedmajor

Repository metrics

Stars
 (35 stars)
PR merge metrics
 (PR metrics pending)

Description

Bug or feature request

  • Bug
  • Feature request

Description of feature (or steps to reproduce if bug)

  1. Insert 10 rows in a model/table
  2. Model.find({where: { nonexistingfield: 'test' } })
  3. Return 10 rows

https://github.com/strongloop/loopback-connector/blob/97d2aea8686a2c66070696a73d23be0a76d14b97/lib/sql.js#L1096-L1100

Expected result

Return 0 (Memory connector return 0 and MongoDB Connector too) In case of SQL this should throw an error ?

Actual result (if bug)

Return all the documents/rows

Additional information (Node.js version, LoopBack version, etc)

Only affect SQL connectors using lib/sql.js

Contributor guide

Research direction
Inspect the filter building logic in lib/sql.js around line 1096-1100. Determine whether the connector validates filter properties against the model schema before generating SQL WHERE clauses. Check if there is a consistent behavior across SQL connectors or if an error should be thrown for non existent fields.
Tech stack
javascript
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60