loktar00/react-lazy-load

Allow passing a root prop to IntersectionObserver

Open

#169 opened on Oct 18, 2023

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (163 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (981 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If using this on elements inside a scrollable div, you need to pass the root prop in order for the offset to work correctly. Otherwise offset is "ignored" and elements are only "visible" when they are actually visibile.

We just need a new root prop of type Element that can be passed optionally to the IntersectionObserver constructor

Contributor guide

Research direction
Add a new optional 'root' prop to the component and pass it to the IntersectionObserver constructor.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactIntersectionObserver
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85