LocalStack CLI doesn't respect version

Open Beginner friendly
#65 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
github-actions, shell
Domain
ci-cd, cli

Research direction

Start in tools/action.yml at the pip install localstack command and trace how the image-tag input is made available to the action. Run the GitHub Actions example from the issue and verify that the installed LocalStack CLI respects the provided version instead of defaulting to the latest release.

Written by the indexing model from the issue text.

Description

Overview

When running the following GitHub Action...

      - name: Start LocalStack
        uses: LocalStack/setup-localstack@v0.3.0
        with:
          install-awslocal: "true"
          use-pro: false
          image-tag: "4.14.0"

...the pro version is not used, however, the code which installs the CLI defaults to the latest CLI version (and not the image-tag value provided:

The file tools/action.yml contains the line...

        which localstack > /dev/null || pip install localstack

...which installs the latest version only.

I believe this line should be modified to accept a version override (image-tag) if one is provided. This may also be the cause of #24.

Dominant language
Shell
Stars
40
Forks
13
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from localstack/setup-localstack

All issues in localstack/setup-localstack

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.