Protocol now required when using `custom.localstack.host`
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- devops
Research direction
Reproduce the reported configuration with serverless-localstack v1.2.0 and v1.2.1, then inspect the change referenced in #243 and the code that builds the LocalStack endpoint. Done should mean a host without a protocol either continues to work as before or produces a clear configuration error, with regression coverage for the behavior.
Written by the indexing model from the issue text.
Description
Description
Since serverless-loaclstack v1.2.1 it appears that the protocol needs to be included in the custom.localstack.host property.
In older versions it appears this was not required.
Configuration
In our serverless configuration we had something similar to:
custom:
localstack:
host: ${env:SOME_VAR, '127.0.0.1'}
i.e. without the protocol (http://).
serverless-localstack v1.2.0:
Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.0
The debug output shows:
Reconfiguring service acm to use http://127.0.0.1:4566
Reconfiguring service amplify to use http://127.0.0.1:4566
Reconfiguring service apigateway to use http://127.0.0.1:4566
serverless-localstack v1.2.1:
Using this with:
- serverless: v3.36.0 (using an older version to be able test with older plugin versions)
- serverless-localstack: v1.2.1
The debug output shows:
Reconfiguring service acm to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service amplify to use 127.0.0.1://127.0.0.1:4566
Reconfiguring service apigateway to use 127.0.0.1://127.0.0.1:4566
which then results in errors such as:
aws: [1] { UnknownEndpoint: Inaccessible host: `127.0.0.1' at port `443'. This service may not be available .....
Additional information
In the documentation the example does include the protocol when setting the custom.localstack.host so I suppose it can also be seen as a configuration error on our end.. but in that case a clearer error message might be useful.
I'm also guessing the change in behavior is caused by #243
- Dominant language
- JavaScript
- Stars
- 542
- Forks
- 92
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from localstack/serverless-localstack
-
Difficulty 1/5 Under an hour Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
-
aws:apigateway status: backlog
Difficulty 4/5 3-5 days Newbie friendliness 35/100
localstack/serverless-localstack#270 · 3 reactions ·
All issues in localstack/serverless-localstack
Similar issues
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
AllTheMods/ATM-10-L#19 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
SignalK/n2k-signalk#345 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
JuliaPluto/PlutoPlotly.jl#72 ·