lm-sys/FastChat

[BUG] RWKV Models are not configured to use Cuda GPU lists.

Open

#1,248 opened on May 15, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,736 forks)batch import
buggood first issue

Repository metrics

Stars
 (38,959 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello,

The file (fastchat/model/rwkv_model.py) has a RWKV stratergy (strategy="cuda fp16") being set that is not imlemented to use the native --gpus or --num-gpus fschat command arguments.

Example, Launching a model worker with (--num-gpus 4 --gpus 0,1,2,3) does not spawn the RWKV instance with these GPU specifications and just uses GPU 1

strategy="cuda fp16"

VS.

strategy="cuda:0 fp16 -> cuda:1 fp16 -> cuda:2 fp16 -> cuda:3 fp16 -> cuda:4 fp16"

Contributor guide

Research direction
Modify the strategy string construction in rwkv model.py to respect the gpus and num gpus arguments.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70