llvm/llvm-project

[clang] Deduplicate `FinishTemplateArgumentDeduction` helper function in `SemaTemplateDeduction.cpp`.

Open

#92,224 opened on May 15, 2024

View on GitHub
 (13 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
clang:frontendgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

In SemaTemplateDeduction.cpp, we have two duplicated versions of FinishTemplateArgumentDeduction. And after #89358, we have three duplications.

Contributor guide

Research direction
Identify the three duplicated `FinishTemplateArgumentDeduction` functions in `SemaTemplateDeduction.cpp` and merge them into a single function, ensuring all callers are updated.
Tech stack
cpp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++clang
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60