C API signature mismatch for LLVMOrcCreateStaticLibrarySearchGeneratorForPath

Open Beginner friendly
#80,097 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
c, cpp
Domain
compilers

Research direction

Start with the declaration in llvm/include/llvm-c/Orc.h at line 1069, then compare it with the implementation in llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp at line 710. Trace the C binding entry point and confirm that the target-triple parameter is handled consistently. Done means the declaration and implementation have matching signatures and the relevant LLVM build or checks pass.

Written by the indexing model from the issue text.

Description

llvm orcjit

llvm-c/Orc.h has the following declaration

LLVMErrorRef LLVMOrcCreateStaticLibrarySearchGeneratorForPath(
    LLVMOrcDefinitionGeneratorRef *Result, LLVMOrcObjectLayerRef ObjLayer,
    const char *FileName, const char *TargetTriple);

however the implementation in OrcV2CBindings.cpp

is missing the target triple argument.

Dominant language
LLVM
Stars
40.6k
Forks
18.7k
Avg merge
18h 16m
Merged PRs (30d)
417

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from llvm/llvm-project

All issues in llvm/llvm-project

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.