llvm/llvm-project

Implement `insertVar` having `Identifier` parameter

Open

#76,839 opened on Jan 3, 2024

View on GitHub
 (6 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
enhancementgood first issuemlir:presburger

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

Currently, the insertVars for PresburgerSpace, IntegerRelation, and PresburgerRelation insert a null identifier for the new var. It would be convenient to have an insertVar which also takes an Identifier parameter.

Contributor guide

Research direction
Look at existing insertVar functions in PresburgerSpace, IntegerRelation, and PresburgerRelation. Understand how they add a null identifier, then create overloaded versions that accept an Identifier parameter and use it.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++LLVM development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70