llvm/llvm-project

Simplify initialisation diagnostic when types are cv-qualified

Open

#73,399 opened on Nov 25, 2023

View on GitHub
 (5 comments) (0 reactions) (2 assignees)C++ (10,782 forks)batch import
clang:diagnosticsgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

I'd like to revise the diagnostic

error: cannot initialize a variable of type 'const icun_status' with an rvalue of type 'int'

to

error: cannot initialize a constant of type 'icun_status' with an rvalue of type 'int'

The const in this diagnostic doesn't appear to be doing much other than ensuring (unnecessary) technical accuracy. I don't think similar nouns exist for volatile and restrict don't exist: they can remain variable.

I have self-assigned, but this is a good candidate for someone looking to get started with Clang, and I'll happily hand it off in that case.

Contributor guide

Research direction
Find the diagnostic message in Clang's source code that produces 'cannot initialize a variable of type ...' and modify it to output 'cannot initialize a constant of type ...' for cv qualified types.
Tech stack
cpp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80