llvm/llvm-project
View on GitHub[clang-tidy] New check for static_cast of an enum class type
Open
#71,543 opened on Nov 7, 2023
check-requestclang-tidygood first issue
Repository metrics
- Stars
- (26,378 stars)
- PR merge metrics
- (Avg merge 1d 2h) (1,000 merged PRs in 30d)
Description
When casting an enum class type using static_cast<T>, this may result in a bug if the type T is not correct. In c++23 we have std::to_underlying which should be used instead. This also is more desirable because if the enum's underlying type is changed later, the casting code is automatically still correct without the need to make the change there, too.
// Fix, must add, if not already present:
#include <utility> // Provides std::to_underlying()
// NOLINTNEXTLINE(performance-enum-size)
enum class EType : int {};
auto main() -> int
{
// NOLINTNEXTLINE(readability-magic-numbers)
EType e {42};
[[maybe_unused]]
// c++23 and later only
// Original code:
// auto i = static_cast<int>(e);
// ~~~~~~~~~~~~~~~~
// ^ bugprone: use std::to_underlying
// Fix:
auto i = std::to_underlying(e);
return 0;
}