llvm/llvm-project

clang-tidy: readability-implicit-bool-conversion not working with std::optional

Open

#56,009 opened on Jun 13, 2022

View on GitHub
 (18 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
clang-tidygood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

I am using llvm-13.0.1

I would expect this to trigger a warning:

std::optional<int> x = false;

Contributor guide

Research direction
Examine the clang tidy check for readability implicit bool conversion in the LLVM source code to identify why std::optional is not handled and propose a fix to detect implicit conversions from bool to std::optional.
Tech stack
cpp
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++LLVM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45