llvm/llvm-project

JavaScriptWrapImports:false doesn't work with ColumnLimit:0

Open

#52,935 opened on Dec 30, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
clang-formatgood first issuejavascript

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

I've run into an issue when using ColumnLimit: 0. When JavaScriptWrapImports is false I'd expect clang-format to leave line breaks in import statements as they are in the original file. Instead, it seems that clang-format force-wraps them:

$ cat .clang-format 
Language: JavaScript
ColumnLimit: 0
JavaScriptWrapImports: false

$ cat testcase.js 
import {aaa, bbb, ccc} from "abc";

$ clang-format-mp-13 testcase.js
import {aaa,
        bbb,
        ccc} from "abc";

Contributor guide

Research direction
Investigate the formatting logic for JavaScript imports in clang format, specifically how ColumnLimit:0 interacts with JavaScriptWrapImports:false. Look at the relevant source files in clang/lib/Format/Format.cpp or similar, focusing on the handling of import statements and line wrapping.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70