llvm/llvm-project

We should probably warn at how 'static inline' variables are odd at namespace scope.

Open

#48,977 opened on Mar 18, 2021

View on GitHub
 (10 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
bugzillac++17clang:diagnosticsconfirmedgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description
Bugzilla Link 49633
Version unspecified
OS All
CC @serberoth,@zygoloid,@TH3CHARLie

Extended Description

" static inline int A; "

seems a little silly, as 'inline' means 'make this definition mergeable', and static means 'this is a unique definition'. It seems that some sort of warning that questions why someone would do this is valuable.

Contributor guide

Research direction
Search for existing similar diagnostics in Clang, such as warnings for static inline functions. Look at the Sema or DiagnoseDeclSpec files to add a warning for static inline variables at namespace scope.
Tech stack
cpp
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++LLVM development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60