llvm/llvm-project

Create bugprone-printf-array check

Open

#40,511 opened on Mar 21, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
bugzillacheck-requestclang-tidygood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

Bugzilla Link 41166
Version unspecified
OS All

Extended Description

It's a common idiom to have a fixed-size buffer of characters allocated on the stack and then to printf into the buffer. Create a check that recommends that the counted versions of functions are used, e.g. prefer snprintf over sprintf.

Example:

void f()
{
  char buff[80];
  sprintf(buff, "Hello, %s!\n", "world");
}

Becomes:

void f()
{
  char buff[80];
  snprintf(buff, sizeof(buff), "Hello, %s!\n", "world");
}

Contributor guide