llvm/llvm-project

Add option to readability-implicit-bool-conversion check to allow implicit conversion *to bool*

Open

#36,323 opened on Apr 2, 2018

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
bugzillaclang-tidyenhancementgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description
Bugzilla Link 36975
Version unspecified
OS All
Reporter LLVM Bugzilla Contributor

Extended Description

From the readability-implicit-bool-conversion check, I'd like to take advantage of these parts:

  • boolean expression/literal to integer,
  • boolean expression/literal to floating.

But not these:

  • integer expression/literal to boolean,
  • floating expression/literal to boolean,
  • pointer/pointer to member/nullptr/NULL to boolean,

Seems like an AllowConversionsToBool option would take care of this. Maybe for completeness/symmetry also a AllowConversionsFromBool option. Both defaulting to 0.

Contributor guide

Research direction
Study how clang tidy checks are configured with options. Look at existing checks with similar options, such as readability implicit bool conversion check source files (e.g., ImplicitBoolConversionCheck.h and .cpp). Implement two new boolean options: AllowConversionsToBool and AllowConversionsFromBool, with default false. Add corresponding tests and update documentation.
Tech stack
cpp
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitLLVM build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65