llvm/llvm-project

include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance)

Open

#34,652 opened on Nov 14, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
bugzillaclang:toolingconfirmedgood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description
Bugzilla Link 35304
Version trunk
OS Linux
Reporter LLVM Bugzilla Contributor
CC @JoeLoser

Extended Description

trunk/llvm/tools/clang/include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance) Function parameter 'NewQualifiedName' should be passed by reference.

Source code is

QualifiedRenameRule(const NamedDecl *ND, std::string NewQualifiedName)

Maybe better code

QualifiedRenameRule(const NamedDecl *ND, const std::string & NewQualifiedName)

Contributor guide

Research direction
Locate the file include/clang/Tooling/Refactoring/Rename/RenamingAction.h, find the constructor of QualifiedRenameRule, and change the second parameter from std::string to const std::string& to avoid a potentially expensive copy.
Tech stack
cpp
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85