llvm/llvm-project

include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance)

Open

#34,652 opened on Nov 14, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (26,378 stars) (10,782 forks)batch import
bugzillaclang:toolingconfirmedgood first issue

Description
Bugzilla Link 35304
Version trunk
OS Linux
Reporter LLVM Bugzilla Contributor
CC @JoeLoser

Extended Description

trunk/llvm/tools/clang/include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance) Function parameter 'NewQualifiedName' should be passed by reference.

Source code is

QualifiedRenameRule(const NamedDecl *ND, std::string NewQualifiedName)

Maybe better code

QualifiedRenameRule(const NamedDecl *ND, const std::string & NewQualifiedName)

Contributor guide

Tech stack
cpp
Domain
toolingperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C++ knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the file include/clang/Tooling/Refactoring/Rename/RenamingAction.h and inspect line 79. The constructor of QualifiedRenameRule takes a std::string NewQualifiedName by value. Change the parameter to const std::string& NewQualifiedName to avoid an unnecessary copy. Ensure that the rest of the code does not require a mutable copy; if so, adjust accordingly. This is a localized, one line change that improves performance.
include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance) · llvm/llvm-project#34652 | Good First Issue