llvm/llvm-project

readability check to convert numerical constants to std::numeric_limits

Open

#34,434 opened on Oct 25, 2017

View on GitHub
 (14 comments) (0 reactions) (1 assignee)C++ (26,378 stars) (10,782 forks)batch import
bugzillacheck-requestclang-tidyconfirmedgood first issue

Description
Bugzilla Link 35086
Version unspecified
OS All
CC @JonasToth

Extended Description

It'll be great to have readability check with will convert ~0, -1 for unsigned integer types to std::numeric_limits::max().

Contributor guide

Tech stack
cpp
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Clang AST matchersLLVM coding styletemplate metaprogramming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests a clang tidy readability check to replace integer constants like `~0` or ` 1` for unsigned types with `std::numeric limits<type>::max()`. The implementation should be located in the clang tools extra directory, following existing patterns such as the `readability *` checks. There is an assignee (@JonasToth) and 14 comments, indicating prior discussion. Review the comments to understand any design decisions or blockers, and examine existing clang tidy checks for style and structure before implementing new AST matchers.
readability check to convert numerical constants to std::numeric_limits · llvm/llvm-project#34434 | Good First Issue