llvm/llvm-project

Readability check for position of constant operand in binary operators

Open

#31,860 opened on Apr 3, 2017

View on GitHub
 (13 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
bugzillacheck-requestclang-tidygood first issue

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description
Bugzilla Link 32513
Version unspecified
OS All

Extended Description

Will be good idea to have readability check for position of constant operand in binary operators.

For example:

if (nullptr == Pointer)

should be fixed as

if (Pointer == nullptr)

or

if (0 < Value)

to

if (Value > 0)

Contributor guide

Research direction
Implement a new clang tidy check in the readability module to detect and fix constant operand on the left side of binary operators. See existing checks like 'readability redundant *' for patterns.
Tech stack
cpp
Domain
compilersdevtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55