llvm/llvm-project

Readability check for position of constant operand in binary operators

Open

#31,860 opened on Apr 3, 2017

View on GitHub
 (13 comments) (0 reactions) (1 assignee)C++ (26,378 stars) (10,782 forks)batch import
bugzillacheck-requestclang-tidygood first issue

Description
Bugzilla Link 32513
Version unspecified
OS All

Extended Description

Will be good idea to have readability check for position of constant operand in binary operators.

For example:

if (nullptr == Pointer)

should be fixed as

if (Pointer == nullptr)

or

if (0 < Value)

to

if (Value > 0)

Contributor guide

Tech stack
cpp
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ experienceAST matchersclang tidy infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine existing clang tidy readability checks for similar patterns (e.g., readability const return type). Study the AST matcher API for BinaryOperator and understand how to check the position of constant operands. Review the LLVM coding standards for operator precedence and discuss on the issue thread to clarify the scope. Look at the issue's comments for any additional requirements or suggestions.