llvm/llvm-project

[MIRSampleProfile] nullptr deref crash when profile sample use file not found

Open

#189,764 opened on Mar 31, 2026

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (10,782 forks)batch import
PGOcrash-on-invalidgood first issuellvm:codegen

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

Trying to reproduce https://github.com/llvm/llvm-project/issues/188897, I failed to pass a valid file for -fprofile-sample-use=; this caused a crash because Reader is nullptr in MIRProfileLoader::runOnFunction. Should be easy to guard against this I think. cc @htyu (author of 958a3d8e2dec95a878dfc9d823861b3a6c674534)

Contributor guide

Research direction
Locate MIRProfileLoader::runOnFunction and add a null pointer check for Reader before dereferencing. Test with a missing profile file.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++LLVM basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70