llvm/llvm-project

[clang-tidy] Add `readability-use-rethrow` check

Open

#189672 opened on Mar 31, 2026

View on GitHub
 (8 comments) (1 reaction) (1 assignee)C++ (26,378 stars) (10,782 forks)batch import
check-requestclang-tidygood first issue

Description

It would be useful to have a clang-tidy check that detects cases where code is clearly trying to rethrow the currently handled exception, but spells it as throw e; instead of throw;.

For example, code like this is easy to write:

try {
  f();
} catch (const std::exception &e) {
  log(e.what());
  throw e;
}

but if the intent is to rethrow the active exception, the clearer spelling is:

try {
  f();
} catch (const std::exception &e) {
  log(e.what());
  throw;
}

The latter expresses the intent directly and avoids the impression that the code is deliberately throwing the caught object as a new exception expression.

Contributor guide

Tech stack
cpp
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ exception handling knowledgeFamiliarity with clang tidy developmentLLVM checkout and build setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Examine existing clang tidy checks in the clang tools extra/clang tidy/ directory for similar patterns. The check should use AST matchers to detect 'throw e' in catch handlers. Look for tests in clang tools extra/test/clang tidy/ and ensure proper integration with the build system. Review maintainer feedback in the issue comments for further guidance.