llvm/llvm-project

Wrong types checked at DAGCombiner::visitSRA(SDNode *N)

Open

#153,543 opened on Aug 14, 2025

View on GitHub
 (7 comments) (0 reactions) (1 assignee)C++ (10,782 forks)batch import
good first issuellvm:SelectionDAG

Repository metrics

Stars
 (26,378 stars)
PR merge metrics
 (Avg merge 1d 2h) (1,000 merged PRs in 30d)

Description

The following check is performed at DAGCombiner::visitSRA(SDNode *N)

if ((ShiftAmt > 0) &&
          TLI.isOperationLegalOrCustom(ISD::SIGN_EXTEND, **TruncVT**) &&
          TLI.isOperationLegalOrCustom(ISD::TRUNCATE, **VT**) &&
          TLI.isTruncateFree(VT, TruncVT)) {
        SDValue Amt = DAG.getShiftAmountConstant(ShiftAmt, VT, DL);
        SDValue Shift = DAG.getNode(ISD::SRL, DL, VT,
                                    N0.getOperand(0), Amt);
        SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, TruncVT,
                                    Shift);
        return DAG.getNode(ISD::SIGN_EXTEND, DL,
                           N->getValueType(0), Trunc);
      }

but it should be

if ((ShiftAmt > 0) &&
          TLI.isOperationLegalOrCustom(ISD::SIGN_EXTEND, **VT**) &&
          TLI.isOperationLegalOrCustom(ISD::TRUNCATE, **TruncVT**) &&
          TLI.isTruncateFree(VT, TruncVT)) {
        SDValue Amt = DAG.getShiftAmountConstant(ShiftAmt, VT, DL);
        SDValue Shift = DAG.getNode(ISD::SRL, DL, VT,
                                    N0.getOperand(0), Amt);
        SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, TruncVT,
                                    Shift);
        return DAG.getNode(ISD::SIGN_EXTEND, DL,
                           N->getValueType(0), Trunc);
      }

this mistake can cause operation marked with expand to reach selection

Contributor guide